davin111 commented on a change in pull request #265: [NEMO-429] SWPP TEAM3 Code
Smell Fix
URL: https://github.com/apache/incubator-nemo/pull/265#discussion_r353720689
##########
File path: common/src/test/java/org/apache/nemo/common/DAGTest.java
##########
@@ -62,28 +62,28 @@ public void testSimpleDAG() {
final DAG<IntegerVertex, Edge<IntegerVertex>> dag = dagBuilder.build();
- assertEquals(dag.getVertices().size(), 5);
- assertEquals(dag.getIncomingEdgesOf(new IntegerVertex(1)).size(), 0);
- assertEquals(dag.getOutgoingEdgesOf(new IntegerVertex(5)).size(), 0);
- assertEquals(dag.getIncomingEdgesOf(new IntegerVertex(3)).size(), 1);
- assertEquals(dag.getOutgoingEdgesOf(new IntegerVertex(4)).size(), 1);
- assertEquals(dag.getTopologicalSort().size(), 5);
+ assertEquals(5, dag.getVertices().size());
+ assertEquals(0, dag.getIncomingEdgesOf(new IntegerVertex(1)).size());
+ assertEquals(0, dag.getOutgoingEdgesOf(new IntegerVertex(5)).size());
+ assertEquals(1, dag.getIncomingEdgesOf(new IntegerVertex(3)).size());
+ assertEquals(1, dag.getOutgoingEdgesOf(new IntegerVertex(4)).size());
+ assertEquals(5, dag.getTopologicalSort().size());
Review comment:
Got it. We'll fix ASAP. Thank you for reviewing. :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
