taehioum commented on a change in pull request #273: [Nemo-429] SWPP TEAM15 Code Smell Fix URL: https://github.com/apache/incubator-nemo/pull/273#discussion_r354661202
########## File path: compiler/frontend/beam/src/main/java/org/apache/nemo/compiler/frontend/beam/transform/GroupByKeyAndWindowDoFnTransform.java ########## @@ -48,10 +48,14 @@ private static final Logger LOG = LoggerFactory.getLogger(GroupByKeyAndWindowDoFnTransform.class.getName()); private final SystemReduceFn reduceFn; + //not serializable, but we don't want it to be transient + //NOSONAR private final Map<K, List<WindowedValue<InputT>>> keyToValues; private transient InMemoryTimerInternalsFactory inMemoryTimerInternalsFactory; private transient InMemoryStateInternalsFactory inMemoryStateInternalsFactory; private Watermark prevOutputWatermark; + //not serializable, but we don't want it to be transient + //NOSONAR Review comment: Removed :) ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
