wynot12 commented on a change in pull request #275: [Nemo-429] SWPP TEAM10 Code
Smell Fix
URL: https://github.com/apache/incubator-nemo/pull/275#discussion_r354836301
##########
File path:
examples/beam/src/main/java/org/apache/nemo/examples/beam/AlternatingLeastSquareInefficient.java
##########
@@ -57,8 +57,8 @@ private AlternatingLeastSquareInefficient() {
PCollection<KV<Integer, float[]>>, PCollection<KV<Integer, float[]>>> {
private final Integer numFeatures;
private final Double lambda;
- private final PCollection<String> rawData;
- private final PCollection<KV<Integer, KV<int[], float[]>>> parsedItemData;
+ transient private final PCollection<String> rawData;
+ transient private final PCollection<KV<Integer, KV<int[], float[]>>>
parsedItemData;
Review comment:
Please update the order of modifiers as `private final transient`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
