wonook commented on a change in pull request #232: [NEMO-411] Bug in
ScheduleGroupPass, OutputTag, DuplicateEdgeGroup
URL: https://github.com/apache/incubator-nemo/pull/232#discussion_r370982445
##########
File path: common/src/main/java/org/apache/nemo/common/ir/IRDAGChecker.java
##########
@@ -348,8 +349,12 @@ void addStreamVertexCheckers() {
}
void addLoopVertexCheckers() {
+ final AtomicInteger distinctIntegerForEmptyOutputTag = new
AtomicInteger(0);
Review comment:
I'll mention that the empty output tags need to be distinguished separately
in loop vertices, whereas it is okay in the EncodingCompressionChecker.
Regarding the AtomicInteger class, I've looked at the article that you've
provided, and have encountered the following answer which takes the approach
that I have taken: https://stackoverflow.com/a/34866143. WDYT?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
