johnyangk commented on a change in pull request #281: [NEMO-437] Support Java version 11 URL: https://github.com/apache/incubator-nemo/pull/281#discussion_r373957675
########## File path: compiler/frontend/beam/src/main/java/org/apache/nemo/compiler/frontend/beam/PipelineTranslationContext.java ########## @@ -55,6 +56,7 @@ private final Map<PValue, TupleTag<?>> pValueToTag; private final Stack<LoopVertex> loopVertexStack; private final Pipeline pipeline; + private AppliedPTransform<?, ?, ?> currentTransform; Review comment: Can you perhaps do without this? Something like this has not been needed, because the current transform that's being visited is explicitly provided through the Beam PipelineVisitor interface. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
