polarcoke2 commented on a change in pull request #289: NEMO-433: Improvement of Task Metrics and Collecting Them For Sampling URL: https://github.com/apache/incubator-nemo/pull/289#discussion_r388124233
########## File path: runtime/common/src/main/java/org/apache/nemo/runtime/common/metric/JobMetric.java ########## @@ -46,7 +46,9 @@ private String vertexProperties; private String edgeProperties; private JsonNode irDagJson; + private volatile DAG<Stage, StageEdge> stageDAG; Review comment: I think it came together when I cherrypicked other parts of code in this class. Apparently, it doesn't do anything, so I'll delete it ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
