polarcoke2 commented on a change in pull request #292:
URL: https://github.com/apache/incubator-nemo/pull/292#discussion_r448872724
##########
File path: common/src/main/java/org/apache/nemo/common/ir/IRDAG.java
##########
@@ -576,6 +577,36 @@ public void insert(final Set<SamplingVertex> toInsert,
modifiedDAG = builder.build(); // update the DAG.
}
+ /**
+ * Insert TaskSizeSplitterVertex in dag.
+ * @param toInsert TaskSizeSplitterVertex to insert.
+ * @param incomingEdgesOfOriginalVertices Edges which goes into original
vertices wrapped by Splitter Vertex.
+ * @param outgoingEdgesOfOriginalVertices Edges which goes out from
original vertices wrapped by Splitter Vertex.
+ * @param edgesWithSplitterVertex Edges which will be inserted to
the dag with Splitter Vertex.
+ */
+ public void insert(final TaskSizeSplitterVertex toInsert,
Review comment:
I've added some tests and checked that this method can pass
testThousandRandomConfigurations. Could you check it? Thanks.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
