taegeonum commented on a change in pull request #304: URL: https://github.com/apache/incubator-nemo/pull/304#discussion_r525991584
########## File path: runtime/executor/src/main/java/org/apache/nemo/runtime/executor/transfer/LocalInputContext.java ########## @@ -0,0 +1,103 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.nemo.runtime.executor.transfer; + +import org.apache.nemo.common.punctuation.Finishmark; +import java.util.Iterator; +import java.util.concurrent.LinkedBlockingQueue; + +/** + * This class provides a data transfer interface to the receiver side when both the sender and the receiver are in the + * same executor. Since the sender doesn't serialize data, the receiver doesn't need to deserialize data when retrieving + * them. + */ + public final class LocalInputContext extends LocalTransferContext { + private final LinkedBlockingQueue queue; + private boolean isOutputContextClosed = false; Review comment: `isOutputContextClosed` -> `outputContextClosed` ########## File path: runtime/executor/src/main/java/org/apache/nemo/runtime/executor/transfer/LocalInputContext.java ########## @@ -0,0 +1,103 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.nemo.runtime.executor.transfer; + +import org.apache.nemo.common.punctuation.Finishmark; +import java.util.Iterator; +import java.util.concurrent.LinkedBlockingQueue; + +/** + * This class provides a data transfer interface to the receiver side when both the sender and the receiver are in the + * same executor. Since the sender doesn't serialize data, the receiver doesn't need to deserialize data when retrieving + * them. + */ + public final class LocalInputContext extends LocalTransferContext { + private final LinkedBlockingQueue queue; + private boolean isOutputContextClosed = false; + + /** + * Creates a new local input context and connect it to {@param localOutputContext}. + * @param localOutputContext the local output context to which this local input context is connected + */ + public LocalInputContext(final LocalOutputContext localOutputContext) { + super(localOutputContext.getExecutorId(), + localOutputContext.getEdgeId(), + localOutputContext.getSrcTaskIndex(), + localOutputContext.getDstTaskIndex()); + this.queue = localOutputContext.getQueue(); + } + + /** + * Checks if the connected output context has already been closed. + * @return true if the connected output context has already been closed. + */ + public boolean isOutputContextClosed() { Review comment: Is this function for test? then could you please add a comment? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
