wonook commented on pull request #306: URL: https://github.com/apache/incubator-nemo/pull/306#issuecomment-806263018
I mean that the changes on the code affects existing functionalities, and that we should keep the side-effects minimal. Existing code writes the metrics periodically, whereas the modified code do not support that, and I'm unsure if that side-effect was intentional. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
