Lemarais commented on a change in pull request #307:
URL: https://github.com/apache/incubator-nemo/pull/307#discussion_r606048988
##########
File path: runtime/driver/src/main/java/org/apache/nemo/driver/NemoDriver.java
##########
@@ -142,7 +142,10 @@ private void setUpLogger() {
*/
private void shutdown() {
LOG.info("Driver shutdown initiated");
- runnerThread.execute(runtimeMaster::terminate);
+ runnerThread.execute(() -> {
+ runtimeMaster.saveMetrics();
Review comment:
i try to minimize side-effects. If it looks like there is no problem to
move that line, I will merge two functions, flushMetric and saveMetric
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
