Kangji commented on a change in pull request #318:
URL: https://github.com/apache/incubator-nemo/pull/318#discussion_r698234330
##########
File path: common/src/main/java/org/apache/nemo/common/ir/IRDAGChecker.java
##########
@@ -486,6 +489,28 @@ void addEncodingCompressionCheckers() {
singleEdgeCheckerList.add(compressAndDecompress);
}
+ void addIntermediateAccumulatorVertexCheckers() {
+ final NeighborChecker shuffleExecutorSet = ((v, inEdges, outEdges) -> {
+ if (v.getPropertyValue(ShuffleExecutorSetProperty.class).isPresent()) {
+ if (inEdges.size() != 1 || outEdges.size() != 1 ||
inEdges.stream().anyMatch(e ->
+ !e.getPropertyValue(CommunicationPatternProperty.class).get()
+ .equals(CommunicationPatternProperty.Value.PARTIAL_SHUFFLE))) {
+ return failure("Only intermediate accumulator vertex can have
shuffle executor set property", v);
Review comment:
Done. I changed the condition more clearly using
`IntermediateAccumulatorVertex` class, and fixed the comments.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
