Lemarais commented on a change in pull request #317:
URL: https://github.com/apache/incubator-nemo/pull/317#discussion_r702384100
##########
File path:
runtime/executor/src/main/java/org/apache/nemo/runtime/executor/datatransfer/OperatorVertexOutputCollector.java
##########
@@ -131,4 +132,33 @@ public void emitWatermark(final Watermark watermark) {
}
}
}
+
+ @Override
+ public void emitLatencymark(final Latencymark latencymark) {
Review comment:
I tried to merge it with a method called emitWatermark. However, until
the methods of writer and transform are divided, merging only methods of
OutputCollector looks not good. emitLatencymark and emitWatermark looks similar
but eventually watermark and latencymark have to be handled differently. So I
suggest remaining both of methods, emitLatencymark and emitWatermark.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]