jeongyooneo commented on code in PR #324:
URL: https://github.com/apache/incubator-nemo/pull/324#discussion_r934090594
##########
common/src/main/java/org/apache/nemo/common/punctuation/Latencymark.java:
##########
@@ -44,26 +44,33 @@ public Latencymark(final String taskId, final long
timestamp) {
}
/**
- * @return the latencymark timestamp
+ * @return the latencymark timestamp.
*/
public long getCreatedTimestamp() {
return createdTimestamp;
}
/**
- * @return the task id where it is created
+ * @return the task id where it is created.
*/
public String getCreatedTaskId() {
return createdTaskId;
}
/**
- * @return the task id of previous task
+ * @return the task id of previous task.
Review Comment:
Could you provide more information in this comments on what `previousTaskId`
is for?
According to the comments of `LatencyMark` class, this class is for
recording task ID and time when the task is created. Does this class assume
that multiple tasks deal with a single source vertex and exchange information
(since there are notions of 'task' and 'previous task') ?
##########
common/src/main/java/org/apache/nemo/common/punctuation/Latencymark.java:
##########
@@ -44,26 +44,33 @@ public Latencymark(final String taskId, final long
timestamp) {
}
/**
- * @return the latencymark timestamp
+ * @return the latencymark timestamp.
*/
public long getCreatedTimestamp() {
return createdTimestamp;
}
/**
- * @return the task id where it is created
+ * @return the task id where it is created.
*/
public String getCreatedTaskId() {
return createdTaskId;
}
/**
- * @return the task id of previous task
+ * @return the task id of previous task.
*/
public String getPreviousTaskId() {
return previousTaskId;
}
+ /**
+ * @return the previously sent time stamp.
Review Comment:
Ditto.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
