sdedic commented on a change in pull request #313: [NETBEANS-194] Don't return
NULL from ShellProjectUtils#launchVMOptions and compilerPathOptions
URL: https://github.com/apache/incubator-netbeans/pull/313#discussion_r158743678
##########
File path:
jshell.support/src/org/netbeans/modules/jshell/project/ShellProjectUtils.java
##########
@@ -372,11 +350,12 @@ public static ClassPath projecRuntimeClassPath(Project
project) {
ShellProjectUtils.findProjectImportedModules(project,
ShellProjectUtils.findProjectModules(project, null))
);
+
Review comment:
The return value of launchVMOptions is actually (sometimes) checked for
null; I agree with changing it to @NonNull, but in that case,
org.netbeans.modules.jshell.env.JShellEnvironment should be modified not to
call JShell.Builder.removeVMOptions. The null check can be removed in the other
callees.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
