matthiasblaesing commented on issue #322: Migrate to Files.new* creation of I/O streams during IDE boot URL: https://github.com/apache/incubator-netbeans/pull/322#issuecomment-356734386 @mdindoffer you need to review this. You introduced failure in at least three of the eight touched modules. I had a quick look at the netbeans "Bootstrap" module and there are at least two problems: - `Stamps#compareAndUpdateFile` catches `FileNotFoundException`, but NIO throws `NoSuchFileException`, this catch needs to be updated (line 439) - `Stamps.Store#store` you switched from `new FileOutputStream(cacheFile, append);` to `Files.newOutputStream(cacheFile.toPath(), StandardOpenOption.APPEND);` you are missing the "file does not yet exists" case (`StandardOpenOption.CREATE`) Please check the other modules. A general rereview of the changes is advised. I advise to check the unittests for all affected modules in master and compare these to the results with your changes applied.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected] For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
