dtrebbien commented on a change in pull request #314: Add a new fix to
BoxedIdentityComparison
URL: https://github.com/apache/incubator-netbeans/pull/314#discussion_r160997887
##########
File path: spi.java.hints/apichanges.xml
##########
@@ -25,6 +25,20 @@
<apidef name="JavaHintsSPI">Java Hints SPI</apidef>
</apidefs>
<changes>
+ <change id="JavaFixUtilities.isPrimary">
+ <api name="JavaHintsSPI"/>
+ <summary>Added JavaFixUtilities.isPrimary() utility</summary>
+ <version major="1" minor="29"/>
Review comment:
Hello @jtulach. Thank you for your review.
I was a little confused by this; I figured that I needed to bump some sort
of version number, but I found that the "spec.version.base" in
`spi.java.hints/nbproject/project.properties` was already set to "1.30.0" in
the project properties:
https://github.com/apache/incubator-netbeans/blob/dd5eb868ec5e8037c77118dbd5e2c53103f1c30e/spi.java.hints/nbproject/project.properties#L20
By the way, I have opened PR #320 to track this API change separately from
the "Add a new fix to BoxedIdentityComparison" changes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
