sdedic commented on a change in pull request #3: NETBEANS-59 - Document split actions URL: https://github.com/apache/incubator-netbeans/pull/3#discussion_r161179072
########## File path: core.multiview/src/org/netbeans/core/multiview/actions/ClearSplitAction.java ########## @@ -0,0 +1,82 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.netbeans.core.multiview.actions; + +import java.awt.event.ActionEvent; +import javax.swing.AbstractAction; +import javax.swing.Action; +import org.netbeans.core.multiview.Splitable; +import org.openide.awt.ActionID; +import org.openide.awt.ActionReference; +import org.openide.awt.ActionRegistration; +import org.openide.util.NbBundle; +import org.openide.windows.TopComponent; +import org.openide.windows.WindowManager; + +/** + * + * @author Christian Lenz (Chrizzly) + */ +@ActionID( + category = "Tools", + id = "org.netbeans.core.multiview.ClearSplitAction" +) +@ActionRegistration( + displayName = "#LBL_ClearSplitAction" +) +@ActionReference(path = "Shortcuts", name = "DOS-C") [email protected]({ + "LBL_ClearSplitAction=&Clear", + "LBL_ValueClearSplit=clearSplit" +}) +public final class ClearSplitAction extends AbstractAction { + + public void initTopComponent(TopComponent tc) { + putValue(Action.NAME, Bundle.LBL_ClearSplitAction()); + //hack to insert extra actions into JDev's popup menu + putValue("_nb_action_id_", Bundle.LBL_ValueClearSplit()); //NOI18N + if (tc instanceof Splitable) { + setEnabled(((Splitable) tc).getSplitOrientation() != -1); + } else { + setEnabled(false); + } + } + + @Override + public void actionPerformed(ActionEvent evt) { + final TopComponent tc = WindowManager.getDefault().getRegistry().getActivated(); + + if (tc != null && ((Splitable) tc).getSplitOrientation() != -1) { Review comment: Maybe better check not for `tc != null` but `tc instanceof Splitable`, which covers bot non-null AND the required interface presence. Maybe even the check for `getSplitOrientation` could move into `clearSplit` ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected] For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
