dtrebbien commented on issue #361: my first refactoring session URL: https://github.com/apache/incubator-netbeans/pull/361#issuecomment-357294532 I think that fixing all of the warnings actually helps. When bug fixing, it is distracting to see all of the yellow warning indicator lines in the sidebar. It makes it more difficult to see what you've changed, as the light green, gray, and pink added/changed/deleted indicator lines are hidden by the yellow lines. It also makes it more difficult to see the locations of breakpoints that you have set. For example, here is the bar for a file in which I have set two breakpoints and made changes to two parts of the file:  One other benefit to general cleanup (in particular, supplying type information on generics) is that it cuts down on the voluminous output of build warnings. I have experimented with submitting the "cleanups" in the same patch as a bug fix (e.g. PR #287), but I don't like this approach. One must be in the mood for examining a lot of small changes that result from cleanup. This work is distracting from reviewing the meat of the patch.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected] For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
