cp7781 commented on a change in pull request #361: my first refactoring session
URL: https://github.com/apache/incubator-netbeans/pull/361#discussion_r161327878
##########
File path:
refactoring.api/src/org/netbeans/modules/refactoring/api/RefactoringSession.java
##########
@@ -210,34 +189,32 @@ public void start(ProgressEvent event) {
@Override
public void step(ProgressEvent event) {
- current = current + progressStep;
+ current += progressStep;
fireProgressListenerStep((int) current);
}
@Override
public void stop(ProgressEvent event) {
- // do not rely on plugins;
+ /* do not rely on plugins; */
Review comment:
A different hotkey is not a good idea for me. I have reconfigured some
actions to use the F1 to F12 keys. And since that is just not enough, I have
started to use the Ctrl key in combination with some characters. Just so, that
I can easily reach them both with my left hand only, and without broken
fingers. At this side of the keyboard there aren't much unused keys left for
reconfiguration. And it would feel unnatural to use two different keystrokes
for similar actions. The /\*\*/ commentation mode is already used for
documentation. Why not keep it like that, and use // mostly for partial code
changes? Since "do not rely on plugins;" can not be evaluated by the compiler,
I would recomment using /\*\*/ commentation mode.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
