cp7781 commented on issue #361: my first refactoring session URL: https://github.com/apache/incubator-netbeans/pull/361#issuecomment-357456763 For now, I wouldn't mind those tests, Daniel. There is some package missing, or something. And it turns red, if the plugin is opened. Just want to fix that. * This computation of the `count` variable indeed looks really awkward. What exactly is getting computed? ```java { int count = COMMIT_STEPS + commits.size() * COMMIT_STEPS + 1; fireProgressListenerStart(0, count); } ``` The `fireProgressListenerStep()` method is getting called at line 117 and 163. Once in a loop over items in the `internalList` member variable, and once at the end of a try block. There seems to be no connection to the call of `commits.size()` in the code listing above. So, this part might be corrupted? * Using lambda expressions is an elegant way to streamline code. Before change, there were two private functions in place, which were both called just once. It not only clutters the navigator window, it also distracts attention away from the requirements. * Thank you for mentioning `Stream.of(...)`. * Doctor, can you please help me? The people say, I'm an idiot, and they are constantly laughing at me. Order of maw means breakfast. I had toast, honey and milk. And a nice girl was talking to me meanwhile. Life is just to good for waking up early.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected] For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
