mdindoffer commented on issue #322: Migrate to Files.new* creation of I/O streams during IDE boot URL: https://github.com/apache/incubator-netbeans/pull/322#issuecomment-357499906 Thanks everyone, I had a closer look at the change and fixed the test regressions. Apart from the two issues reported by @matthiasblaesing, there was a missing create option in NbLogging. The PR also revealed a bug in the SystemFileSystemTest which was failing due to leaked file streams. Fixed the test. Do I need to squash?
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected] For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
