jlahoda opened a new pull request #368: [NETBEANS-251] WidthEstimator is doing 
estimates based on Symbols, bu?
URL: https://github.com/apache/incubator-netbeans/pull/368
 
 
   ?t that's no desirable, as all trees are printed as they are by VeryPretty.
   
   The immediate issue was that the EqualsHashCodeGenerator tried to attribute 
trees like "other.foo", which left errors in the tree. The tree was than 
directly used for code generation. The WidthEstimator was then doing (among 
other things):
   t.owner != t.packge().modle.unnamedPackage
   
   But for the error t.packge() returns the root package, which does not have a 
module, hence the NPE.
   
   The test could be rewritten to handle this, but I don't think the 
WidthEstimator(/VeryPretty) should do any tricks with symbols. These should 
simply print the trees as they are. (Import handling is done on a different 
level.)
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

Reply via email to