lbruun commented on a change in pull request #367: [NETBEANS-281] Add ASF
license template
URL: https://github.com/apache/incubator-netbeans/pull/367#discussion_r161397838
##########
File path:
apisupport.ant/src/org/netbeans/modules/apisupport/project/resources/layer.xml
##########
@@ -261,11 +261,6 @@
<attr name="displayName"
bundlevalue="org.netbeans.modules.apisupport.project.ui.Bundle#Templates/Licenses/license-cddl-netbeans-sun.txt"/>
<attr name="mavenLicenseURL"
stringvalue="http://www.netbeans.org/cddl-gplv2.html"/>
</file>
- <file name="license-apache20-netbeans.txt"
url="license-apache20-netbeans.txt">
Review comment:
Note : The license template file *must* be supplied by `projectui` module so
that it can be used by any type of project which wishes to use it. In the old
days the license header for CDDL NetBeans project lived in `apisupport.ant`
because it was a very special template which didn't have relevance outside of
NetBeans itself. But this is different now. The ASF header is relevant for any
project under the ASF, not just Apache NetBeans itself. This is why `projectui`
is now the provider of the ASF lic template, just like for any other generic
lic template.
The headers used in the old days was a special version of a CDDL header
which applied only to the NetBeans project. The header used now is nothing
special to NetBeans. This is what is different from old world.
We need to make ASF header _generally_ available to any project that wishes
to use it. This is why it needs to live in `projectui` module, not in
`apisupport.ant` project. I hope this makes sense.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
