dtrebbien commented on a change in pull request #364: [NETBEANS-252] Fix CG
adding methods to enum constant bodies
URL: https://github.com/apache/incubator-netbeans/pull/364#discussion_r161404405
##########
File path:
java.source.base/src/org/netbeans/modules/java/source/save/CasualDiff.java
##########
@@ -5119,6 +5128,7 @@ private int diffTreeImpl0(JCTree oldT, JCTree newT,
JCTree parent /*used only fo
if (oldT == newT)
return elementBounds[0];
+ assert oldT != null;
Review comment:
I changed it to:
```java
if (oldT == newT) {
return elementBounds[0];
}
if (oldT == null) {
throw new IllegalArgumentException("Null is not allowed in parameters.");
}
```
To start with `if (oldT == null)` would require:
```java
if (oldT == null) {
if (newT == null) {
return elementBounds[0];
} else {
throw new IllegalArgumentException("Null is not allowed in
parameters.");
}
} else if (oldT == newT) {
return elementBounds[0];
}
```
.. but this duplicates the `return elementBounds[0];` line.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
