sdedic commented on a change in pull request #320: Add the
JavaFixUtilities.isPrimary() utility API
URL: https://github.com/apache/incubator-netbeans/pull/320#discussion_r161446811
##########
File path: spi.java.hints/apichanges.xml
##########
@@ -25,6 +25,20 @@
<apidef name="JavaHintsSPI">Java Hints SPI</apidef>
</apidefs>
<changes>
+ <change id="JavaFixUtilities.isPrimary">
+ <api name="JavaHintsSPI"/>
+ <summary>Added JavaFixUtilities.isPrimary() utility</summary>
+ <version major="1" minor="29"/>
+ <date day="5" month="12" year="2017"/>
+ <compatibility addition="yes"/>
+ <description>
+ <p>
+ The utility method JavaFixUtilities.isPrimary() was added.
+ This API checks whether a specified tree can be used in
+ places where a Primary expression is required.
+ </p>
+ </description>
+ </change>
Review comment:
`project.properties` already lists version `1.30.0`. You need to bump the
version number to a higher value in both `project.properties` and here AND make
dependency on that new version from `java.hints` module.
Otherwise java.hints might autoupdate while this library could remain old
(since java.hints requires 1.29, the library without your fix is 1.30 already
so it's OK for dependency system). Users will get LinkageError.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
