neilcsmith-net commented on a change in pull request #415: [NETBEANS-365] Allow
Harness to be more Friendly
URL: https://github.com/apache/incubator-netbeans/pull/415#discussion_r166990394
##########
File path: nbbuild/antsrc/org/netbeans/nbbuild/ParseProjectXml.java
##########
@@ -991,7 +993,16 @@ private String computeClasspath(String myCNB,
ModuleListParser modules, Dep[] de
if (!dep.impl && /* #71807 */ dep.run && !recursive &&
!runtime) {
String friends = attr.getValue("OpenIDE-Module-Friends");
if (friends != null && !Arrays.asList(friends.split(" *,
*")).contains(myCNB)) {
- throw new BuildException("The module " + myCNB + " is
not a friend of " + depJar, getLocation());
+ String friendIssue = "The module " + myCNB + " is not
a friend of " + depJar;
+ if
(Boolean.parseBoolean(getProject().getProperty(PROP_FRIENDLY_MODULES))) {
+ log(friendIssue, Project.MSG_WARN);
+ } else {
+ log("The " + depJar.getName() + " is a non-stable
API/SPI. It is only available for its friends.", Project.MSG_ERR);
Review comment:
+10 (OK, 1!) to that. And external libs, too, please! :smile: Friend makes
sense to me for splitting out functionality, but maybe we need something else
entirely for non-stable?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org
For additional commands, e-mail: notifications-h...@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
