matthiasblaesing commented on issue #421: Providing exact steps used to rebuild the Equinox JAR URL: https://github.com/apache/incubator-netbeans/pull/421#issuecomment-365393490 I saw two thinks here: 1. It would be good if the intention of the patch would be documented (why and how) - would updating to a newer version of equinox also be an option? 2. I would prefer, that the equinox source code is not added as a submodule (see: https://github.com/apache/incubator-netbeans/pull/421/files#diff-0c8d99427179470b4f6a7e707e07fc42). I don't see a reason to include the directory/submodule in the repository. The procedure looks sensible (maybe we can build it on-the-fly in the future, but for now it looks good).
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org For additional commands, e-mail: notifications-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
