eirikbakke commented on issue #437: [NETBEANS-404] Adjust Javadoc font size to 
editor's zoom level, and avoid all-monospace font
URL: 
https://github.com/apache/incubator-netbeans/pull/437#issuecomment-378031405
 
 
   Matthias, let me see if I can manage to understand your comment. Am I 
correct that this is an objection to the _existing_ use of  
"css.addStyleSheet(htmlKit.getStyleSheet())" that is currently present in 
HTMLDocView.setBodyFontInCSS?
   
   Is there globally shared state here that that I am not aware of? It seems 
the HTMLEditorKit instance that is modified in 
"css.addStyleSheet(htmlKit.getStyleSheet())" in HTMLDocView belongs to that 
HTMLDocView instance only. But there's a comment in HTMLDocView saying "the 
style sheet is shared by all HTMLEditorKits". Is that the problem here?
   
   Also note that the stylesheet change here is context-sensitive--depending on 
which editor the documentation popup is opened for, the font size may be 
different. Should the tweak still, in your opinion, be located in 
org.netbeans.swing.plaf ?
   
   I probably do not have enough familiarity with the related code to do a 
large refactoring here.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org
For additional commands, e-mail: notifications-h...@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

Reply via email to