JaroslavTulach commented on a change in pull request #471: [NETBEANS-491] Fix 
issue reporting
URL: https://github.com/apache/incubator-netbeans/pull/471#discussion_r179374594
 
 

 ##########
 File path: uihandler/src/org/netbeans/modules/uihandler/UIHandler.java
 ##########
 @@ -245,8 +249,12 @@ public void actionPerformed(ActionEvent ev) {
         Window w = SwingUtilities.windowForComponent(c);
         if (w != null) {
             w.dispose();
-        } 
-        Installer.RP.post(this);
+        }
 
 Review comment:
   I don't think this is a correct change as it doesn't follow the specified 
behavior in 
https://github.com/apache/incubator-netbeans/blob/master/uihandler/arch.xml - I 
would assume that some tests shall start falling after removing 
`Installer.RP.post(this)` - didn't they?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org
For additional commands, e-mail: notifications-h...@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

Reply via email to