emilianbold commented on issue #3: NETBEANS-59 - Document split actions
URL: https://github.com/apache/incubator-netbeans/pull/3#issuecomment-379169897
   Well, I was just trying to understand what you want to accomplish. My patch 
seems much shorter and does the same (or not?). I'm not certain what your 
refactoring adds -- it anything it introduces complexity.
   *But*, if I were to refactor, I'd take into account that `SplitAction` is 
registered in `mf-layer.xml` under `Menu/View`.
   Ideally, since we have standalone actions now for each horizontal split / 
vertical split / clear action then we should create
   <folder name="Menu">
           <folder name="View">
               <folder name="Split">
   and register your `SplitDocumentHorizontallyAction` and 
`SplitDocumentVerticallyAction` with an `@ActionReference` under `path = 
   *Then* you have to take into account that `SplitAction` seems to have a 
toggle via `isSplitingEnabled` and that the actions are enabled/disabled based 
on the activated TopComponent.
   Of course, what's missing with using the layer is that you cannot disable 
the whole `View/Split` menu if it's a layer folder.
   So, as far as refactoring go it seems you stopped too early. In which case 
it seems better not to refactor anything and keep the patch more minimal.
   Anyhow, I would like to conclude with this PR. It seems to have taken 
   I also don't want to be nitpicking and stop progress. So, I'm going to 
unsubscribe from this PR. Feel free to either continue working on the patch 
based on my comments or your own ideas or commit it as is, etc.

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:

With regards,
Apache Git Services

To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org
For additional commands, e-mail: notifications-h...@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:

Reply via email to