matthiasblaesing commented on a change in pull request #494: Adding 
LICENSE/NOTICE/DISCLAIMER to NBMs, packing OSGi jars into NBMs…
URL: https://github.com/apache/incubator-netbeans/pull/494#discussion_r181556225
 
 

 ##########
 File path: nbbuild/templates/common.xml
 ##########
 @@ -427,7 +427,11 @@
         <fileset dir="${cluster}" id="module.executable.files" 
includes="${nbm.executable.files}"/>
     </target>
 
-    <target name="nbm" 
depends="init,netbeans,-nbm-prompt-for-storepass,-init-executables" 
description="Build NBM archive.">
+    <target name="-init-extra.nbm.files" unless="extra.nbm.files.provided"> 
<!-- fallback -->
+        <zipfileset dir="${cluster}" id="extra.nbm.files" 
includes="[NOTHING]"/>
 
 Review comment:
   I don't understand the "[NOTHING]" here - what is the intention?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org
For additional commands, e-mail: notifications-h...@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

Reply via email to