matthiasblaesing commented on a change in pull request #494: Adding LICENSE/NOTICE/DISCLAIMER to NBMs, packing OSGi jars into NBMs… URL: https://github.com/apache/incubator-netbeans/pull/494#discussion_r181556190
########## File path: nbbuild/antsrc/org/netbeans/nbbuild/extlibs/CreateLicenseSummary.java ########## @@ -289,6 +296,18 @@ private void evaluateBinaries(final PrintWriter licenseWriter, final PrintWriter List<String> ignoredPatterns = VerifyLibsAndLicenses.loadPatterns("ignored-binary-overlaps"); if (build != null) findBinaries(build, binaries2LicenseHeaders, crc2License, new HashMap<>(), "", testBinariesAreUnique, ignoredPatterns); + if (moduleFiles != null) { + for (Resource r : moduleFiles) { + try (InputStream is = r.getInputStream()) { + long crc = computeCRC32(is); + Map<String, String> headers = crc2License.get(crc); + if (headers != null) { + binaries2LicenseHeaders.put(r.getName(), headers); + } + } + System.err.println(r.as(File.class)); Review comment: `System.err` see other locations ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org For additional commands, e-mail: notifications-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists