sdedic commented on a change in pull request #509: [NETBEANS-498] JDK10-LVTI: Provide fix hint to convert var to explicit type URL: https://github.com/apache/incubator-netbeans/pull/509#discussion_r183621542
########## File path: java.hints/src/org/netbeans/modules/java/hints/jdk/ConvertVarToExplicitType.java ########## @@ -0,0 +1,147 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.netbeans.modules.java.hints.jdk; + +import com.sun.source.tree.CompilationUnitTree; +import com.sun.source.tree.ExpressionTree; +import com.sun.source.tree.Scope; +import com.sun.source.tree.Tree; +import com.sun.source.tree.VariableTree; +import com.sun.source.util.TreePath; +import java.util.Arrays; +import java.util.Collections; +import java.util.HashSet; +import java.util.List; +import java.util.Set; +import javax.lang.model.SourceVersion; +import javax.lang.model.element.ElementKind; +import javax.lang.model.type.TypeKind; +import javax.lang.model.type.TypeMirror; +import javax.tools.Diagnostic; +import org.netbeans.api.java.source.CompilationInfo; +import org.netbeans.api.java.source.ElementHandle; +import org.netbeans.api.java.source.JavaSource; +import org.netbeans.api.java.source.TreeMaker; +import org.netbeans.api.java.source.WorkingCopy; +import org.netbeans.spi.editor.hints.ErrorDescription; +import org.netbeans.spi.java.hints.ErrorDescriptionFactory; +import org.netbeans.spi.java.hints.Hint; +import org.netbeans.spi.java.hints.HintContext; +import org.netbeans.spi.java.hints.JavaFix; +import org.netbeans.spi.java.hints.JavaFix.TransformationContext; +import org.netbeans.spi.java.hints.TriggerPattern; +import org.openide.util.NbBundle.Messages; + +/** + * Hint to convert type in local variable declaration from 'var' to explicit + * type + * + * @author rtaneja + */ +@Hint(displayName = "#DN_ConvertVarToExplicitType", description = "#DESC_ConvertVarToExplicitType", category = "rules15", minSourceVersion = "10") +@Messages("MSG_ConvertibleToExplicitType=Convert var to explicit type") +public class ConvertVarToExplicitType { + + @TriggerPattern("$mods$ $type $var = $init") //NOI18N + public static ErrorDescription convertVarToExplicitType(HintContext ctx) { + + if (!isLocalVarType(ctx)) { + return null; + } + TreePath treePath = ctx.getPath(); + + TreePath initTreePath = ctx.getVariables().get("$init"); //NOI18N + ExpressionTree t = ctx.getInfo().getTreeUtilities().parseExpression(initTreePath.getLeaf().toString(), null); + Scope s = ctx.getInfo().getTrees().getScope(ctx.getPath()); + TypeMirror initTypeMirror = ctx.getInfo().getTreeUtilities().attributeTree(t, s); + + TypeMirror variableTypeMiror = ctx.getInfo().getTrees().getElement(treePath).asType(); + + // variable initializer type should be same as variable type. + if ((variableTypeMiror.getKind() == TypeKind.ERROR) || (!ctx.getInfo().getTypes().isSameType(variableTypeMiror, initTypeMirror))) { + return null; + } + return ErrorDescriptionFactory.forTree(ctx, ctx.getPath(), Bundle.MSG_ConvertibleToExplicitType(), + new JavaFixImpl(ctx.getInfo(), ctx.getPath()).toEditorFix()); + } + + /** + * Fix for converting local 'var' type to explicit variable type + * + */ + private static final class JavaFixImpl extends JavaFix { + + public JavaFixImpl(CompilationInfo info, TreePath tp) { + super(info, tp); + } + + @Override + @Messages("FIX_convertVarToExplicitType=Replace var with explicit type") + protected String getText() { + return Bundle.FIX_convertVarToExplicitType(); + } + + @Override + protected void performRewrite(TransformationContext tc) throws Exception { + WorkingCopy wc = tc.getWorkingCopy(); + CompilationUnitTree cut = wc.getCompilationUnit(); + TreePath statementPath = tc.getPath(); + + TreeMaker make = wc.getTreeMaker(); + + if (statementPath.getLeaf().getKind() == Tree.Kind.VARIABLE) { + VariableTree oldVariableTree = (VariableTree) statementPath.getLeaf(); + TypeMirror type = wc.getTrees().getTypeMirror(statementPath); + VariableTree newVariableTree = make.Variable( + oldVariableTree.getModifiers(), + oldVariableTree.getName(), + make.Type(type), + oldVariableTree.getInitializer() + ); + wc.rewrite(oldVariableTree, newVariableTree); + } + } + + } + + /** + * + * @param ctx : HintContext + * @return true if pre-conditions for hint to be enable is meet + */ + private static boolean isLocalVarType(HintContext ctx) { Review comment: Suggestion: this may be a good addition to Utilities in hints.errors (there are other type/tree related checks and manipulations). @jlahoda what do you think - shouldn't TreeUtilities check for lang version in their `isVarType` ? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org For additional commands, e-mail: notifications-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
