ocafebabe commented on a change in pull request #535: [NETBEANS-519] Bump
Eclipse JGit dependency to latest version
URL: https://github.com/apache/incubator-netbeans/pull/535#discussion_r186310197
##########
File path: o.eclipse.jgit/build.xml
##########
@@ -21,5 +21,11 @@
-->
<project name="o.eclipse.jgit" default="build" basedir=".">
<import file="../nbbuild/templates/projectized.xml"/>
+ <target name="-process.release.files">
+ <unzip src="external/org.eclipse.jgit-4.11.0.201803080745-r.jar"
dest="external/tmp" />
+ <jar
destfile="external/org.eclipse.jgit-4.11.0.201803080745-r-nbm.jar"
manifest="manifest.mf">
+ <fileset dir="external/tmp" />
+ </jar>
+ </target>
Review comment:
Well, this is based on a recommendation from a previous reviewer
(@emilianbold). JGit is an OSGi bundle and it depends on some OSGi dependencies
that aren't available as OSGi bundles in NetBeans (like JSCH for instance).
With this change I'm repackaging the library as a regular NetBeans module!
See this post for more details:
https://lists.apache.org/thread.html/ac7fc5d9e2ddaa8ccd7a43dde4bc7fa80a254a11a8a4dc376811cebb@%3Cdev.netbeans.apache.org%3E
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org
For additional commands, e-mail: notifications-h...@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
