-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67570/#review204695
-----------------------------------------------------------


Ship it!




Looks good for me. Could got in release90 branch as well.

- Sven Reimers


On Juni 13, 2018, 1:20 nachm., Emilian Bold wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67570/
> -----------------------------------------------------------
> 
> (Updated Juni 13, 2018, 1:20 nachm.)
> 
> 
> Review request for netbeans.
> 
> 
> Repository: netbeans
> 
> 
> Description
> -------
> 
> Adds Apache feather and hyperlink in Start Page, image created manually from 
> the Apache feather SVG
> 
> 
> Diffs
> -----
> 
>   welcome/licenseinfo.xml 23e18b1c6 
>   welcome/src/org/netbeans/modules/welcome/content/Constants.java bf93dbb51 
>   welcome/src/org/netbeans/modules/welcome/content/Logo.java c77132bd8 
>   welcome/src/org/netbeans/modules/welcome/resources/Bundle.properties 
> 782ffab9e 
>   welcome/src/org/netbeans/modules/welcome/resources/apache_feather.png 
> PRE-CREATION 
>   welcome/src/org/netbeans/modules/welcome/resources/apache_feather_dark.png 
> PRE-CREATION 
>   welcome/src/org/netbeans/modules/welcome/resources/oracle_logo.png 
> d6168216ee63493e06833e7ad4ae364e40e51387 
>   welcome/src/org/netbeans/modules/welcome/resources/oracle_logo_dark.png 
> d6168216ee63493e06833e7ad4ae364e40e51387 
>   welcome/src/org/netbeans/modules/welcome/ui/BottomBar.java e74df096f 
> 
> 
> Diff: https://reviews.apache.org/r/67570/diff/1/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Emilian Bold
> 
>

Reply via email to