matthiasblaesing commented on a change in pull request #716: [NETBEANS-1074] Module Review groovy.samples URL: https://github.com/apache/incubator-netbeans/pull/716#discussion_r211093912
########## File path: nbbuild/rat-exclusions.txt ########## @@ -157,6 +157,7 @@ platform/openide.util/test/unit/src/org/openide/util/LookupUsesRequestProcessorT **/nbproject/build-impl.xml **/nbproject/genfiles.properties **/nbproject/jfx-impl.xml +groovy.samples/sample_src/**/groovy-build.xml Review comment: The header in the file is pretty clear, so aggreed: ``` *** GENERATED FROM project.xml - DO NOT EDIT *** *** EDIT ../build.xml INSTEAD *** ``` I would change the pattern though to: `**/nbproject/groovy-build.xml` That would also catch the file `./websvc.restkit/test/qa-functional/data/projects/TestClientTestApp/nbproject/groovy-build.xml` and would be in line with the other generated file in the `nbproject` and independent of the concrete project. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected] For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
