matthiasblaesing commented on issue #940: [NETBEANS-1074] Module Review 
web.struts
URL: 
https://github.com/apache/incubator-netbeans/pull/940#issuecomment-430405306
 
 
   @sarveshkesharwani I created a squashed version with my suggestions applied:
   https://github.com/matthiasblaesing/incubator-netbeans/tree/github-pr-940-2
   You are credited as the author, I'll be present as committer. If you agree 
with the changes, I'll merge the changes to master as presented in the above 
referenced branch. in that process I would also let github close this PR.
   
   For `struts-config_1_3-custom.dtd`: Yes for me the build failed. I think I 
know what happend: You did a build with the file present, removed the file and 
rebuild. This could have worked, if the build system did not detect changes, it 
would not try to rebuild the generated classes and it would look like building 
without the file succeeded. I ran the build after running `git clean -f -x -d` 
which basicly removes everything not part of the repository.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

Reply via email to