fvogler commented on a change in pull request #978: [NETBEANS-1481] Fix
handling of eager module fragments (regression netbeans 9.0)
URL: https://github.com/apache/incubator-netbeans/pull/978#discussion_r227155530
##########
File path: platform/o.n.bootstrap/src/org/netbeans/ModuleManager.java
##########
@@ -1681,7 +1681,9 @@ public boolean hasToEnableCompatModules(Set<Module>
modules) throws IllegalArgum
private void maybeAddToEnableList(Set<Module> willEnable, Set<Module>
mightEnable, Module m, boolean okToFail) {
if (! missingDependencies(m).isEmpty()) {
- assert okToFail : "Module " + m + " had unexpected problems: " +
missingDependencies(m) + " (willEnable: " + willEnable + " mightEnable: " +
mightEnable + ")";
+ if (!okToFail) {
Review comment:
This was introduced by the PR #847 and has changed behaviour of module
loading from NetBeans 9.0 to 10. From my point of view it should be an
exception or a log message, throwing an assertion error is not the right
solution here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists