matthiasblaesing commented on issue #948: [NETBEANS-1294] Fix failing unit tests in groovy.editor. URL: https://github.com/apache/incubator-netbeans/pull/948#issuecomment-432335890 I'm not a groovy expert, but: - I ran the unittests and found them working - visited the some of the completion changes and they look sane - visited infrastructure changes and they also look sane => From my POV this can be merged
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected] For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
