JaroslavTulach commented on a change in pull request #973: GraalJS parser JAR
removed from distribution. Created convenience mod…
URL: https://github.com/apache/incubator-netbeans/pull/973#discussion_r228088678
##########
File path: ergonomics/ide.ergonomics/nbproject/project.xml
##########
@@ -262,6 +262,16 @@
<code-name-base>org.netbeans.modules.server</code-name-base>
<compile-dependency/>
</test-dependency>
+ <test-dependency>
+
<code-name-base>org.netbeans.modules.java.source.nbjavac</code-name-base>
+ <compile-dependency/>
+ <test/>
+ </test-dependency>
+ <test-dependency>
+
<code-name-base>org.netbeans.libs.nashorn</code-name-base>
+ <compile-dependency/>
+ <test/>
Review comment:
This is fine, portable. As far as I know it includes the test dependencies
of `org.netbeans.libs.nashorn` project on classpath - couldn't the
`webcommon/libs.oracle.jsparser/build/webcommon/modules/org-netbeans-libs-oracle-jsparser.jar`
be part of test dependencies of `org.netbeans.libs.nashorn`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists