sdedic commented on a change in pull request #973: GraalJS parser JAR removed
from distribution. Created convenience mod…
URL: https://github.com/apache/incubator-netbeans/pull/973#discussion_r228150315
##########
File path: ergonomics/ide.ergonomics/nbproject/project.xml
##########
@@ -262,6 +262,16 @@
<code-name-base>org.netbeans.modules.server</code-name-base>
<compile-dependency/>
</test-dependency>
+ <test-dependency>
+
<code-name-base>org.netbeans.modules.java.source.nbjavac</code-name-base>
+ <compile-dependency/>
+ <test/>
+ </test-dependency>
+ <test-dependency>
+
<code-name-base>org.netbeans.libs.nashorn</code-name-base>
+ <compile-dependency/>
+ <test/>
Review comment:
Yes, test dependencies. In this case, we need to include a library wrapper
module: a JAR + a wrapped library relative to that JAR. The JAR is find, test
infrastructure will build a jar out of `test/unit/classes` into
`testdist/webcommon` folder. But the wrapped library is not there, so module
load fails with ZipException
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists