eirikbakke edited a comment on issue #859: HiDPI icons for window system icons 
on Windows and Mac
URL: 
https://github.com/apache/incubator-netbeans/pull/859#issuecomment-434367267
 
 
   @emilianbold Would you mind having a quick look to OK the API change here, 
which is just the addition of a new utility class "VectorIcon"?
   
   I looked at the retina-related work you did in the past. This PR should 
should not interfere with any of that, as this PR only touches the LAF-related 
icons, and does not change ImageUtilities in any way. It would be great to 
eventually merge your work as well.
   
   (There are basically two possible approaches to doing HiDPI icons: either 
via MultiResolutionImage, or via vector-painted custom implementations of the 
Icon class. I think both approaches should be supported--this PR deals with the 
vector painting approach, while your previous retina work deals with the 
MultiResolutionImage approach. The MultiResolutionImage approach currently does 
not work properly on Windows, due to 
https://bugs.openjdk.java.net/browse/JDK-8212226 , but surely it will work in 
the long-term.)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

Reply via email to