matthiasblaesing commented on issue #1000: [NETBEANS-583] Avoid errors related 
to ClosedByInterruptException
URL: 
https://github.com/apache/incubator-netbeans/pull/1000#issuecomment-434898079
 
 
   I did not review yet and I'm currently wondering if it is worth it. With the 
knowledge of today (underlying issue fixed in JDK, unhandled error situation 
newly introduced) I would not have merged it. So  I openly ask - should we just 
revert commits:
   
   - f84b25e042e1a3eeb88afcc12805cd74bc5e4fd7 (first part of fix)
   - 4b82e6adb31e294c74fd2fa99779ce9e27ae6184 (origin)
   
   From my POV we are introducing much code to work-around a non-problem on 
recent JDKs. In one year no-one can explain what made us introduce 
`org.openide.util.io.FilesNI`. git revert does not fully run clean, but 
manually reverting should be perfectly doable.
   
   I'll tag @mdindoffer here to get his opinion.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

Reply via email to