matthiasblaesing commented on a change in pull request #959: [NETBEANS-1074] Module review j2ee.platform URL: https://github.com/apache/incubator-netbeans/pull/959#discussion_r232382730
########## File path: enterprise/j2ee.platform/external/binaries-list ########## @@ -1 +1,18 @@ -27E9711AA35C39EF455BFD900D544BACB99C0E89 javaee-doc-api.jar +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +CC1024CBFA7C3A9CC84485603A7D458BFD2F3B4A javax:javaee-api:7.0:javadoc Review comment: @arusinha sorry - no. You fixed one instance, but not the underlying problem. You could fix all "in-tree" uses of the file, but then there could still be modules relying on the layout. In the tree there are at least five other locations which would need to be checked. I don't know why the different structure was choosen in the past, but what is done, is done. I would repackage the maven file. The logic in the build file looks like this: ```xml <!-- Hook into harness "-process.release.files" task --> <target name="-process.release.files" depends="prepare-doc"/> <!-- Check if generated doc file was already generated --> <target name="-check-prepared-doc"> <condition property="j2ee.platform.doccreated" value="present"> <and> <available file="external/generated-javaee-api-7.0-javadoc.jar" /> </and> </condition> </target> <target name="prepare-doc" depends="-check-prepared-doc" unless="j2ee.platform.doccreated"> <delete file="external/generated-javaee-api-7.0-javadoc.jar" /> <!-- repackage doc file into the format netbeans used prior to switching to the maven central artefact --> <jar destfile="external/generated-javaee-api-7.0-javadoc.jar"> <zipfileset src="external/javaee-api-7.0-javadoc.jar" includes="**" prefix="docs/api" /> </jar> </target> ``` That way you don't introduce changes to the file and can remove the changes to the other modules and don't need to investigate all users of this module. For this to work, there needs to be another license file created and the generated file must be used when packaging the final file. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected] For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
