emilianbold commented on issue #998: [NETBEANS-1586] Make ImageUtilities.createDisabledIcon work with HiDPI icons URL: https://github.com/apache/incubator-netbeans/pull/998#issuecomment-437701299 You probably know more about this area than me. There are a few aspects in my mind here: * generally speaking icons won't move around displays with different scalings. So, it seems better to always cache and risk a bad icon when move than to never cache and pay some computational cost for every repaint. Not caching is correct, but is it really worth the price? (Then again, we have no measurement of the actual cost). * the old (existing?) NetBeans code cared a lot about image caching, so I assume they had some metrics for this fear. * there is something odd about the design too. So `DisabledIcon` wraps an `Icon`. But then during paint time: it creates a temporary image, paints the icon there, creates a disables *image* then paints that. Considering icons are the closest we have to vector graphics (ie. non-raster) in AWT/Swing, this roundtrip is annoying to me. I guess I'm surprised we can't do `RGBImageFilter` at Graphics2D level, like we can do a `setTransform`.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected] For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
