sdedic commented on a change in pull request #917: Fragments for libs.javafx 
with JavaFX 11 implementation
URL: https://github.com/apache/incubator-netbeans/pull/917#discussion_r234900868
 
 

 ##########
 File path: 
ergonomics/ide.ergonomics/src/org/netbeans/modules/ide/ergonomics/fod/FeatureInfo.java
 ##########
 @@ -213,17 +216,37 @@ int isProject(FeatureProjectFactory.Data data) {
         return Collections.unmodifiableSet(cnbs);
     }
     
-    public final Set<String> getExtraModules() {
-        String cnbs = properties.getProperty("extra.modules"); // NOI18N
-        TreeSet<String> s = new TreeSet<String>();
-        if (cnbs != null) {
-            s.addAll(Arrays.asList(cnbs.split(",")));
+    public final Set<ExtraModuleInfo> getExtraModules() {
+        Set<ExtraModuleInfo> s = new LinkedHashSet<>();
+        for (int i = 0; ; i++) {
+            String propName = i == 0 ? "extra.modules" : "extra.modules." + i; 
// NOI18N
+            String cnbPattern = properties.getProperty(propName);
+            if (cnbPattern == null) {
+                break;
+            }
+            String rec = properties.getProperty(propName + 
".recommended.min.jdk"); // NOI18N
 
 Review comment:
   This changes `extra.modules` from a comma-separated list to single-module 
name. Could it made backwards compatible, at least for `extra.modules` property 
key ? The code could still explit the string by `,` and iterate the module 
name(s) with the same min JDK recommendation.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

Reply via email to