dukescript commented on a change in pull request #917: Fragments for
libs.javafx with JavaFX 11 implementation
URL: https://github.com/apache/incubator-netbeans/pull/917#discussion_r235249642
##########
File path:
ergonomics/ide.ergonomics/src/org/netbeans/modules/ide/ergonomics/fod/FeatureInfo.java
##########
@@ -213,17 +216,37 @@ int isProject(FeatureProjectFactory.Data data) {
return Collections.unmodifiableSet(cnbs);
}
- public final Set<String> getExtraModules() {
- String cnbs = properties.getProperty("extra.modules"); // NOI18N
- TreeSet<String> s = new TreeSet<String>();
- if (cnbs != null) {
- s.addAll(Arrays.asList(cnbs.split(",")));
+ public final Set<ExtraModuleInfo> getExtraModules() {
+ Set<ExtraModuleInfo> s = new LinkedHashSet<>();
+ for (int i = 0; ; i++) {
+ String propName = i == 0 ? "extra.modules" : "extra.modules." + i;
// NOI18N
+ String cnbPattern = properties.getProperty(propName);
+ if (cnbPattern == null) {
+ break;
+ }
+ String rec = properties.getProperty(propName +
".recommended.min.jdk"); // NOI18N
Review comment:
Yes, the new format allows to associate `recommended.min.jdk` to each module
- not just have one `recommended.min.jdk` per feature. This is internal only
contract. There is no point in keeping old format parsing code, when all places
were updated to the new one.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists