jtulach commented on a change in pull request #1037: Allow to open projects
without nb-javac on supported JDKs.
URL:
https://github.com/apache/incubator-netbeans/pull/1037#discussion_r237108353
##########
File path:
ergonomics/ide.ergonomics/src/org/netbeans/modules/ide/ergonomics/fod/FeatureProjectFactory.java
##########
@@ -440,7 +443,24 @@ public void onEnable(ProgressHandle progressHandle) {
}
public void onError(String message) {
- error = message;
+ SpecificationVersion jdk = new
SpecificationVersion(System.getProperty("java.specification.version"));
+ FeatureInfo[] fi = Arrays.copyOf(additional, additional.length
+ 1);
+ fi[additional.length] = info;
+ boolean required = false;
+
+ for (FeatureInfo i : fi) {
Review comment:
This code snippet reminds me code snippet somewhere else. Consider
extracting into a method.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
