sdedic commented on a change in pull request #1043: Release100 apidocbranding
URL:
https://github.com/apache/incubator-netbeans/pull/1043#discussion_r237649901
##########
File path: nbbuild/javadoctools/build.xml
##########
@@ -31,7 +31,13 @@
<import file="../default.xml"/>
<target name="build-javadoc"
depends="-jdk-init,-load-build-properties,init-tasks,set-buildnumber"
description="Builds Javadoc documentation for modules; on branches pass e.g.
-Djavadoc.web.root=http://bits.netbeans.org/6.7/javadoc">
- <resolvelist name="allmodules" path="modules.fullpath" dir="${nb_all}"
list="${nb.clusters.list}" modules="${config.javadoc.all}"/>
Review comment:
If I understood well this change, the module list is explicit already and
there's no reason to search and translate it using cluster dirs which all
reside under `${nb_all}` anyway right ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists