jmborer commented on a change in pull request #1042: Update
TestOutputListenerProvider.java to fix [NETBEANS-635]
URL:
https://github.com/apache/incubator-netbeans/pull/1042#discussion_r237856296
##########
File path:
java/maven/test/unit/src/org/netbeans/modules/maven/output/TestOutputListenerProviderTest.java
##########
@@ -126,9 +129,179 @@ public void testFailfafeSeparateTestOuput() {
visitor.resetVisitor();
provider.processLine("Tests run: 1, Failures: 1, Errors: 0, Skipped:
0, Time elapsed: 0.057 sec \r\r\t\n\r\n<<< FAILURE! ", visitor);
assertNotNull(visitor.getOutputListener());
+
+ provider.sequenceFail("mojo-execute#surefire:test", visitor);
+
+ }
+
+ /**
+ * Test based on the output generated by Surefire 2.18.1.
+ */
+ public void testSurefireTestOuput_2_18_1() {
+ OutputVisitor visitor = new OutputVisitor();
+ visitor.resetVisitor();
+ provider.sequenceStart("mojo-execute#failsafe:integration-test",
visitor);
+ assertNull(visitor.getOutputListener());
+ visitor.resetVisitor();
+ provider.processLine("Surefire report directory:
/target/surefire-reports", visitor);
+ assertNull(visitor.getOutputListener());
+ assertEquals(provider.outputDir, "/target/surefire-reports");
+ visitor.resetVisitor();
+
+ provider.processLine("Running com.example.SampleTest", visitor);
+ assertEquals(provider.runningTestClass, "com.example.SampleTest");
+ assertNull(visitor.getOutputListener());
+ visitor.resetVisitor();
+
+ // Failed tests.
+ provider.processLine("Tests run: 1, Failures: 1, Errors: 0, Skipped:
0, Time elapsed: 0.003 sec <<< FAILURE! - in com.example.SampleTest", visitor);
+ // there must be a listener to navigate to test reports
+ assertNotNull(visitor.getOutputListener());
+ visitor.resetVisitor();
+
+ // Successful tests.
+ provider.processLine("Tests run: 1, Failures: 0, Errors: 0, Skipped:
0", visitor);
+ // there must be a listener to navigate to test reports
+ assertNull(visitor.getOutputListener());
+ visitor.resetVisitor();
+ provider.sequenceFail("mojo-execute#surefire:test", visitor);
+ }
+
+ /**
+ * Test based on the output generated by Surefire 2.18.1 with "Print Maven
output logging level" enabled
+ */
+ public void testSurefireTestOuput_2_18_1_withLogging() {
+ OutputVisitor visitor = new OutputVisitor();
+ visitor.resetVisitor();
+ provider.sequenceStart("mojo-execute#failsafe:integration-test",
visitor);
+ assertNull(visitor.getOutputListener());
+ visitor.resetVisitor();
+ provider.processLine("[INFO] Surefire report directory:
/target/surefire-reports", visitor);
+ assertNull(visitor.getOutputListener());
+ assertEquals(provider.outputDir, "/target/surefire-reports");
+ visitor.resetVisitor();
+
+ provider.processLine("Running com.example.SampleTest", visitor);
+ assertEquals(provider.runningTestClass, "com.example.SampleTest");
+ assertNull(visitor.getOutputListener());
+ visitor.resetVisitor();
+
+ // Failed tests.
+ provider.processLine("Tests run: 1, Failures: 1, Errors: 0, Skipped:
0, Time elapsed: 0.003 sec <<< FAILURE! - in com.example.SampleTest", visitor);
+ // there must be a listener to navigate to test reports
+ assertNotNull(visitor.getOutputListener());
+ visitor.resetVisitor();
+
+ // Successful tests.
+ provider.processLine("Tests run: 1, Failures: 0, Errors: 0, Skipped:
0", visitor);
+ // there must be a listener to navigate to test reports
+ assertNull(visitor.getOutputListener());
+ visitor.resetVisitor();
+ provider.sequenceFail("mojo-execute#surefire:test", visitor);
+ }
+
+ /**
+ * Test based on the output generated by Surefire 2.19.1
+ */
+ public void testSurefireTestOuput_2_19_1() {
+ OutputVisitor visitor = new OutputVisitor();
+ visitor.resetVisitor();
+ provider.sequenceStart("mojo-execute#failsafe:integration-test",
visitor);
+ assertNull(visitor.getOutputListener());
+ visitor.resetVisitor();
+
+ // Surefire report directory: /target/surefire-reports is not
generated by default only with mvn -e
+ provider.processLine("Surefire report directory:
/target/surefire-reports", visitor);
+ assertNull(visitor.getOutputListener());
+ assertEquals(provider.outputDir, "/target/surefire-reports");
+ visitor.resetVisitor();
+
+ provider.processLine("Running com.example.SampleTest", visitor);
+ assertEquals(provider.runningTestClass, "com.example.SampleTest");
+ assertNull(visitor.getOutputListener());
+ visitor.resetVisitor();
+
+ // Failed tests.
+ provider.processLine("Tests run: 1, Failures: 1, Errors: 0, Skipped:
0, Time elapsed: 0.003 sec <<< FAILURE! - in com.example.SampleTest", visitor);
+ // there must be a listener to navigate to test reports
+ assertNotNull(visitor.getOutputListener());
+ visitor.resetVisitor();
+
+ // Successful tests.
+ provider.processLine("Tests run: 1, Failures: 0, Errors: 0, Skipped:
0", visitor);
+ // there must be a listener to navigate to test reports
+ assertNull(visitor.getOutputListener());
+ visitor.resetVisitor();
+ provider.sequenceFail("mojo-execute#surefire:test", visitor);
+ }
+
+ /**
+ * Test based on the output generated by Surefire 2.19.1 with logging
turned on
+ */
+ public void testSurefireTestOuput_2_19_1_withLogging() {
+ OutputVisitor visitor = new OutputVisitor();
+ visitor.resetVisitor();
+ provider.sequenceStart("mojo-execute#failsafe:integration-test",
visitor);
+ assertNull(visitor.getOutputListener());
+ visitor.resetVisitor();
+ // Surefire report directory: /target/surefire-reports is not
generated by default only with mvn -e
+ provider.processLine("[INFO] Surefire report directory:
/target/surefire-reports", visitor);
+ assertNull(visitor.getOutputListener());
+ assertEquals(provider.outputDir, "/target/surefire-reports");
+ visitor.resetVisitor();
+
+ provider.processLine("Running com.example.SampleTest", visitor);
+ assertEquals(provider.runningTestClass, "com.example.SampleTest");
+ assertNull(visitor.getOutputListener());
+ visitor.resetVisitor();
+
+ // Failed tests.
+ provider.processLine("Tests run: 1, Failures: 1, Errors: 0, Skipped:
0, Time elapsed: 0.003 sec <<< FAILURE! - in com.example.SampleTest", visitor);
+ // there must be a listener to navigate to test reports
+ assertNotNull(visitor.getOutputListener());
+ visitor.resetVisitor();
+
+ // Successful tests.
+ provider.processLine("Tests run: 1, Failures: 0, Errors: 0, Skipped:
0", visitor);
+ // there must be a listener to navigate to test reports
+ assertNull(visitor.getOutputListener());
+ visitor.resetVisitor();
provider.sequenceFail("mojo-execute#surefire:test", visitor);
+ }
+
+ /**
+ * Test based on the output generated by Surefire 2.22.1 as well with
3.0.0-M3 with logging turned on
+ */
+ public void testSurefireTestOuput_2_22_later_withLogging() {
+ OutputVisitor visitor = new OutputVisitor();
+ visitor.resetVisitor();
+ provider.sequenceStart("mojo-execute#failsafe:integration-test",
visitor);
+ assertNull(visitor.getOutputListener());
+ visitor.resetVisitor();
+ // Surefire report directory: /target/surefire-reports is not
generated by default only with mvn -e
+ provider.processLine("[INFO] Surefire report directory:
/target/surefire-reports", visitor);
+ assertNull(visitor.getOutputListener());
+ assertEquals(provider.outputDir, "/target/surefire-reports");
+ visitor.resetVisitor();
+
+ provider.processLine("[INFO] Running com.example.SampleTest", visitor);
+ assertEquals(provider.runningTestClass, "com.example.SampleTest");
+ assertNull(visitor.getOutputListener());
+ visitor.resetVisitor();
+
+ // Failed tests.
+ provider.processLine("[ERROR] Tests run: 1, Failures: 1, Errors: 0,
Skipped: 0, Time elapsed: 0.003 sec <<< FAILURE! - in com.example.SampleTest",
visitor);
+ // there must be a listener to navigate to test reports
+ assertNotNull(visitor.getOutputListener());
+ visitor.resetVisitor();
+
+ // Successful tests.
+ provider.processLine("[INFO] Tests run: 1, Failures: 0, Errors: 0,
Skipped: 0", visitor);
+ // there must be a listener to navigate to test reports
+ assertNull(visitor.getOutputListener());
+ visitor.resetVisitor();
+ provider.sequenceFail("mojo-execute#surefire:test", visitor);
}
-
-}
+}
Review comment:
OK. Usually I use a new line a the very end of my sources files. Here, I
just overlooked it. Shall I fix it?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
